Make application default to uncurried at the lambda level. #6894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
force-pushed
the
test-treat-every-lambda-apply-as-uncurried
branch
from
3ac17cb to
4ffa73a
Compare
cristianoc
force-pushed
the
test-treat-every-lambda-apply-as-uncurried
branch
from
4ffa73a to
de4896a
Compare
|
@cknitt this is still ongoing, but asking a review to take a look if it's on the right track. |
cristianoc
force-pushed
the
test-treat-every-lambda-apply-as-uncurried
branch
from
de4896a to
2c2c472
Compare
cknitt
reviewed
Jul 21, 2024
jscomp/test/gpr_3875_test.js
Outdated
| result.contents = "Some x, f returns false"; | ||
| } | ||
| return; | ||
| if (exit === 2) { |
There was a problem hiding this comment.
Interesting that this causes an if to be generated instead of a switch.
cristianoc
force-pushed
the
test-treat-every-lambda-apply-as-uncurried
branch
from
2c2c472 to
08b6806
Compare
This was referenced Jul 22, 2024
cristianoc
force-pushed
the
test-treat-every-lambda-apply-as-uncurried
branch
from
08b6806 to
33798cc
Compare
cristianoc
changed the title
cknitt
reviewed
Jul 22, 2024
cristianoc
force-pushed
the
test-treat-every-lambda-apply-as-uncurried
branch
from
33798cc to
eb5e36a
Compare
The effect is that a bunch of applications are treated as curried applications.
cristianoc
force-pushed
the
test-treat-every-lambda-apply-as-uncurried
branch
from
eb5e36a to
0f69786
Compare
cknitt
reviewed
Jul 23, 2024
jscomp/ml/typecore.ml
Outdated
| @@ -2178,7 +2166,7 @@ and type_expect_ ?type_clash_context ?in_function ?(recarg=Rejected) env sexp ty | |||
| | _ -> false in | |||
|
|
|||
| if fully_applied && not is_primitive then | |||
There was a problem hiding this comment.
So the if could actually be removed now.
There was a problem hiding this comment.
We still have foo(x, ...) for partial application.
|
Merging this into the parent PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to restore lost optimisations in uncurried mode: #6879 so every runtime use of curry is gone.